runtime/vm/flow_graph_compiler_x64.cc - Issue 10466006: Implemented in ia32: branch, strict compare, instance setter, instanceof and assertassigneable with…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 10466006: Implemented in ia32: branch, strict compare, instance setter, instanceof and assertassigneable with… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_x64.cc

===================================================================

--- runtime/vm/flow_graph_compiler_x64.cc (revision 8212)

+++ runtime/vm/flow_graph_compiler_x64.cc (working copy)

@@ -464,7 +464,6 @@

// - RAX: object.

// - RDX: instantiator type arguments or raw_null.

// - RCX: instantiator or raw_null.

-// Destroys RCX and RDX.

// Returns:

// - object in RAX for successful assignable check (or throws TypeError).

// Performance notes: positive checks must be quick, negative checks can be slow

@@ -692,7 +691,7 @@

__ Bind(&is_instance);

__ LoadObject(RAX, negate_result ? bool_false : bool_true);

__ Bind(&done);

- __ popq(RDX); // Remove pushed instantiator type arguments..

+ __ popq(RDX); // Remove pushed instantiator type arguments.

__ popq(RCX); // Remove pushed instantiator.

}

« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | runtime/vm/intermediate_language_ia32.cc » ('J')