Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 10466005: Only reauthorize passwords. Don't reauthorize private keys. (Closed)

Created:
8 years, 6 months ago by Mark Mentovai
Modified:
8 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Only reauthorize passwords. Don't try to reauthorize private keys, because they were getting deleted instead of reauthorized. BUG=130738 TEST=Put a private key in your Keychain, give Chrome access, and run through the reauthorization workflow. The private key should not be touched by reauthorization. You can ensure you get the reauthorization workflow by running: $ defaults delete com.google.Chrome KeychainReauthorizeInAppMay2012 $ defaults delete com.google.Chrome KeychainReauthorizeInAppMay2012Success and launching a copy of Chrome with this change present. To get a private key in your Keychain, open /Applications/Utilities/Keychain Access.app and choose Certificate Assistant/Create a Certificate from the Keychain Access menu. For this test, it's OK to accept the defaults. Find the private key added to your Keychain, select it and press command-I for Get Info, switch to the Access Control tab, and add Chrome to the list of applications allowed access to the private key. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140081

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M chrome/browser/mac/keychain_reauthorize.mm View 1 2 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
8 years, 6 months ago (2012-06-01 19:05:10 UTC) #1
Nico
lgtm looks a bit weird to me with a switch instead of an if, but ...
8 years, 6 months ago (2012-06-01 19:09:14 UTC) #2
Mark Mentovai
8 years, 6 months ago (2012-06-01 19:18:14 UTC) #3
Thanks, Nico!

Powered by Google App Engine
This is Rietveld 408576698