Issue 10459078: Issue 3341. Fix for file handle leak

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10459078: Issue 3341. Fix for file handle leak (Closed)

Created:
8 years, 6 months ago by scheglov

Modified:
8 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 3341. Fix for file handle leak http://code.google.com/p/dart/issues/detail?id=3341 R=brianwilkerson@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8210

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -18 lines)			Patch
	M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/io/FileUtilities.java	View		2 chunks	+11 lines, -18 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years, 6 months ago (2012-06-01 17:59:53 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10459078/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/io/FileUtilities.java
(right):

https://chromiumcodereview.appspot.com/10459078/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/io/FileUtilities.java:2:
* Copyright (c) 2011, the Dart project authors.
nit: copyright year

Expand Messages | Collapse Messages