Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 10459059: ninja windows: support resource only DLLs (Closed)

Created:
8 years, 6 months ago by scottmg
Modified:
8 years, 6 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

ninja windows: support resource only DLLs 'ResourceOnlyDLL' translates to '/NOENTRY' in linker flags :/. Allows creating DLLs that contain only localized resources but no code. R=thakis@chromium.org BUG=chromium:130621 Committed: https://code.google.com/p/gyp/source/detail?r=1409

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M pylib/gyp/msvs_emulation.py View 1 chunk +1 line, -0 lines 0 comments Download
M test/win/rc-build/hello.gyp View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scottmg
8 years, 6 months ago (2012-05-31 21:35:12 UTC) #1
Nico
8 years, 6 months ago (2012-05-31 21:36:45 UTC) #2
lgtm

why the ':-/'?

Powered by Google App Engine
This is Rietveld 408576698