Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1775)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 10459053: Real fix for breakage: if type in DECLARE_FLAG differs from DEFINE_FLAG, windows compiler is the on… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_ia32.cc
===================================================================
--- runtime/vm/intermediate_language_ia32.cc (revision 8169)
+++ runtime/vm/intermediate_language_ia32.cc (working copy)
@@ -5,6 +5,8 @@
#include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
#if defined(TARGET_ARCH_IA32)
+#include "vm/intermediate_language.h"
+
#include "vm/flow_graph_compiler.h"
#include "vm/locations.h"
#include "vm/stub_code.h"
@@ -13,7 +15,7 @@
namespace dart {
-DECLARE_FLAG(bool, optimization_counter_threshold);
+DECLARE_FLAG(int, optimization_counter_threshold);
DECLARE_FLAG(bool, trace_functions);
// True iff. the arguments to a call will be properly pushed and can
@@ -74,7 +76,7 @@
Function::ZoneHandle(compiler->parsed_function().function().raw());
__ LoadObject(temp, function);
__ incl(FieldAddress(temp, Function::usage_counter_offset()));
- /*if (CodeGenerator::CanOptimize()) {
+ if (CodeGenerator::CanOptimize()) {
// Do not optimize if usage count must be reported.
__ cmpl(FieldAddress(temp, Function::usage_counter_offset()),
Immediate(FLAG_optimization_counter_threshold));
@@ -86,7 +88,7 @@
__ popl(temp); // Remove argument.
__ popl(result); // Restore result.
__ Bind(&not_yet_hot);
- } */
+ }
}
if (FLAG_trace_functions) {
const Function& function =
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698