Clean up d8 ArrayBuffer implementation and fix bug in readbuffer:

Clean up d8 ArrayBuffer implementation and fix bug in readbuffer:

- Separate CreateExternalArrayBuffer function.
- Properly create buffers for arrays constructed with size argument only.
- Finalization of data array is tied to buffer object exclusively.
- Get rid of hidden buffer reference in array objects and size header in data.
- Use 'new' instead of 'malloc' in readbuffer.
- Test cases for additional array and buffer properties.

R=mstarzinger@chromium.org
BUG=
TEST=

Committed: https://code.google.com/p/v8/source/detail?r=11698

[Michael Starzinger, 2012-06-01 09:43:28]

LGTM (if comments are addressed). I like that change.

https://chromiumcodereview.appspot.com/10459047/diff/1/src/d8.cc
File src/d8.cc (right):

https://chromiumcodereview.appspot.com/10459047/diff/1/src/d8.cc#newcode1029
src/d8.cc:1029: void* data = ReadChars(*filename, &length);
Why this change? I would prefer it to stay "char*" if possible.

https://chromiumcodereview.appspot.com/10459047/diff/1/src/d8.cc#newcode1037
src/d8.cc:1037: persistent_buffer.MarkIndependent();
I think we are missing a positive adjustment of the external memory amount
statistics here. The following line should do the trick.

V8::AdjustAmountOfExternalAllocatedMemory(length);

[rossberg, 2012-06-01 11:42:35]

https://chromiumcodereview.appspot.com/10459047/diff/1/src/d8.cc
File src/d8.cc (right):

https://chromiumcodereview.appspot.com/10459047/diff/1/src/d8.cc#newcode1029
src/d8.cc:1029: void* data = ReadChars(*filename, &length);
On 2012/06/01 09:43:28, Michael Starzinger wrote:
> Why this change? I would prefer it to stay "char*" if possible.

Actually, changed it to uint8_t, which is more adequate.

https://chromiumcodereview.appspot.com/10459047/diff/1/src/d8.cc#newcode1037
src/d8.cc:1037: persistent_buffer.MarkIndependent();
On 2012/06/01 09:43:28, Michael Starzinger wrote:
> I think we are missing a positive adjustment of the external memory amount
> statistics here. The following line should do the trick.
> 
> V8::AdjustAmountOfExternalAllocatedMemory(length);

Done.