Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 10459012: Issue 3223. Don't warn about types compatibility is one of the types was inferred (Closed)

Created:
8 years, 6 months ago by scheglov
Modified:
8 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 3223. Don't warn about types compatibility is one of the types was inferred http://code.google.com/p/dart/issues/detail?id=3223 R=brianwilkerson@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8080

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -2 lines) Patch
A compiler/java/com/google/dart/compiler/type/InferredType.java View 1 chunk +34 lines, -0 lines 1 comment Download
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 3 chunks +11 lines, -2 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
8 years, 6 months ago (2012-05-29 20:14:30 UTC) #1
Brian Wilkerson
Are those the only two places where we're inferring/propagating types? If not, I think we ...
8 years, 6 months ago (2012-05-29 20:25:46 UTC) #2
scheglov
8 years, 6 months ago (2012-05-29 21:27:51 UTC) #3
On 2012/05/29 20:25:46, Brian Wilkerson wrote:
> Are those the only two places where we're inferring/propagating types? If not,
I
> think we need to update the other places to create an inferred type as well
> (either in this or another CL). Otherwise, LGTM.

  Yes, there are only two places where we set inferred types.

Powered by Google App Engine
This is Rietveld 408576698