Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10459005: Fixed AppID registration. (Closed)

Created:
8 years, 6 months ago by Vitaly Buka (NO REVIEWS)
Modified:
8 years, 6 months ago
Reviewers:
gene
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fixed AppID registration. Removed user confirmation on missing state file. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139381

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -24 lines) Patch
M cloud_print/service/win/cloud_print_service.cc View 1 7 chunks +34 lines, -21 lines 0 comments Download
M cloud_print/service/win/cloud_print_service.rgs View 1 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Vitaly Buka (NO REVIEWS)
8 years, 6 months ago (2012-05-29 07:38:30 UTC) #1
gene
lgtm
8 years, 6 months ago (2012-05-29 18:14:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10459005/1
8 years, 6 months ago (2012-05-29 18:15:17 UTC) #3
commit-bot: I haz the power
Failed to apply patch for cloud_print/service/win/cloud_print_service.rgs: While running patch -p1 --forward --force; patching file cloud_print/service/win/cloud_print_service.rgs ...
8 years, 6 months ago (2012-05-29 18:15:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10459005/8002
8 years, 6 months ago (2012-05-29 19:17:27 UTC) #5
commit-bot: I haz the power
Failed to apply patch for cloud_print/service/win/cloud_print_service.rgs: While running patch -p1 --forward --force; patching file cloud_print/service/win/cloud_print_service.rgs ...
8 years, 6 months ago (2012-05-29 19:17:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10459005/7002
8 years, 6 months ago (2012-05-29 21:41:43 UTC) #7
commit-bot: I haz the power
8 years, 6 months ago (2012-05-29 21:41:55 UTC) #8 
Failed to apply patch for cloud_print/service/win/cloud_print_service.rgs:
While running patch -p1 --forward --force;
patching file cloud_print/service/win/cloud_print_service.rgs
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file
cloud_print/service/win/cloud_print_service.rgs.rej

Powered by Google App Engine
This is Rietveld 408576698