Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3390)

Unified Diff: chrome/browser/ui/webui/options2/certificate_manager_handler2.cc

Issue 10458069: Reland: Fix imported server certs being distrusted in NSS 3.13. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix the test failures Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/options2/certificate_manager2_browsertest.js ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options2/certificate_manager_handler2.cc
diff --git a/chrome/browser/ui/webui/options2/certificate_manager_handler2.cc b/chrome/browser/ui/webui/options2/certificate_manager_handler2.cc
index a8ed12492e6d94f9de29b9e783901f4990beecb3..707ea970cb8b7dd49fd19a909663f80142db7550 100644
--- a/chrome/browser/ui/webui/options2/certificate_manager_handler2.cc
+++ b/chrome/browser/ui/webui/options2/certificate_manager_handler2.cc
@@ -810,8 +810,10 @@ void CertificateManagerHandler::ImportServerFileRead(int read_errno,
}
net::CertDatabase::ImportCertFailureList not_imported;
+ // TODO(mattm): Add UI for trust. http://crbug.com/76274
bool result = certificate_manager_model_->ImportServerCert(
selected_cert_list_,
+ net::CertDatabase::TRUST_DEFAULT,
&not_imported);
if (!result) {
ShowError(
@@ -890,6 +892,8 @@ void CertificateManagerHandler::ImportCATrustSelected(const ListValue* args) {
return;
}
+ // TODO(mattm): add UI for setting explicit distrust, too.
+ // http://crbug.com/128411
net::CertDatabase::ImportCertFailureList not_imported;
bool result = certificate_manager_model_->ImportCACerts(
selected_cert_list_,
« no previous file with comments | « chrome/browser/ui/webui/options2/certificate_manager2_browsertest.js ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698