Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10458069: Reland: Fix imported server certs being distrusted in NSS 3.13. (Closed)

Created:
8 years, 6 months ago by mattm
Modified:
8 years, 6 months ago
Reviewers:
James Hawkins, stevenjb, wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, arv (Not doing code reviews), darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Reland: Fix imported server certs being distrusted in NSS 3.13. Add support for intentionally distrusting certs. (Not exposed in the UI yet.) BUG=116411 TEST=CertDatabaseNSSTest TBR=stevenjb@chromium.org,jhawkins@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139979

Patch Set 1 #

Patch Set 2 : fix the test failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+573 lines, -683 lines) Patch
M chrome/browser/certificate_manager_model.h View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/certificate_manager_model.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/cros/onc_network_parser.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/cros/onc_network_parser_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/options2/browser_options.html View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/options2/options.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options2/options_bundle.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/certificate_manager2_browsertest.js View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/certificate_manager_handler2.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +7 lines, -4 lines 0 comments Download
M chrome/common/net/x509_certificate_model_unittest.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp View 3 chunks +19 lines, -5 lines 0 comments Download
M net/base/cert_database.h View 3 chunks +15 lines, -5 lines 0 comments Download
M net/base/cert_database_nss.cc View 2 chunks +37 lines, -14 lines 0 comments Download
M net/base/cert_database_nss_unittest.cc View 1 11 chunks +394 lines, -35 lines 0 comments Download
M net/base/cert_database_openssl.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M net/net.gyp View 3 chunks +0 lines, -6 lines 0 comments Download
D net/third_party/mozilla_security_manager/nsNSSCertTrust.h View 1 chunk +0 lines, -128 lines 0 comments Download
D net/third_party/mozilla_security_manager/nsNSSCertTrust.cpp View 1 chunk +0 lines, -378 lines 0 comments Download
M net/third_party/mozilla_security_manager/nsNSSCertificateDB.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/third_party/mozilla_security_manager/nsNSSCertificateDB.cpp View 6 chunks +64 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mattm
Test failed on the linux shared bot. I guess it had some trust values that ...
8 years, 6 months ago (2012-06-01 00:54:01 UTC) #1
wtc
Patch set 2 LGTM.
8 years, 6 months ago (2012-06-01 01:57:20 UTC) #2
mattm
TBRing owners since there aren't any other changes vs the original (http://codereview.chromium.org/9940001/)
8 years, 6 months ago (2012-06-01 02:01:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mattm@chromium.org/10458069/1001
8 years, 6 months ago (2012-06-01 02:02:29 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-01 06:00:01 UTC) #5 
Change committed as 139979

Powered by Google App Engine
This is Rietveld 408576698