runtime/vm/flow_graph_compiler_x64.h - Issue 10458031: In generated code for x64 don't load object's class directly from class_ field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_x64.h

Issue 10458031: In generated code for x64 don't load object's class directly from class_ field. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Eliminate CoreClass helpers on ia32/x64 and use class ids for array classes. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_x64.h

diff --git a/runtime/vm/flow_graph_compiler_x64.h b/runtime/vm/flow_graph_compiler_x64.h

index 93cd028774b48ab016e12f8074ba88e9117c41e1..33fd19b027995bc67b037e97316727d4239ebef3 100644

--- a/runtime/vm/flow_graph_compiler_x64.h

+++ b/runtime/vm/flow_graph_compiler_x64.h

@@ -133,7 +133,7 @@ class FlowGraphCompiler : public FlowGraphVisitor {

intptr_t try_index);

// Type checking helper methods.

- void CheckClasses(const GrowableArray<const Class*>& classes,

+ void CheckClassIds(const GrowableArray<intptr_t>& class_ids,

Label* is_instance_lbl,

Label* is_not_instance_lbl);

RawSubtypeTestCache* GenerateInlineInstanceof(intptr_t cid,

« no previous file with comments | « runtime/vm/code_generator_ia32.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »