Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Unified Diff: runtime/vm/assembler_ia32.cc

Issue 10458031: In generated code for x64 don't load object's class directly from class_ field. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Eliminate CoreClass helpers on ia32/x64 and use class ids for array classes. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_ia32.h ('k') | runtime/vm/assembler_x64.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_ia32.cc
diff --git a/runtime/vm/assembler_ia32.cc b/runtime/vm/assembler_ia32.cc
index 7bd7d49e553ee56214ee3f3a71a2082a5c2c8d5a..9c8624f66a6902722f6aead4b30b3ca51d6b6ca4 100644
--- a/runtime/vm/assembler_ia32.cc
+++ b/runtime/vm/assembler_ia32.cc
@@ -1562,11 +1562,20 @@ void Assembler::EmitGenericShift(int rm,
}
-void Assembler::LoadClassOfObject(Register result,
- Register object,
- Register scratch) {
+void Assembler::LoadClassId(Register result, Register object) {
+ ASSERT(RawObject::kClassTagBit == 16);
+ ASSERT(RawObject::kClassTagSize == 16);
+ const intptr_t class_id_offset = Object::tags_offset() +
+ RawObject::kClassTagBit / kBitsPerByte;
+ movzxw(result, FieldAddress(object, class_id_offset));
+}
+
+
+void Assembler::LoadClass(Register result,
+ Register object,
+ Register scratch) {
ASSERT(scratch != result);
- LoadClassIndexOfObject(scratch, object);
+ LoadClassId(scratch, object);
movl(result, FieldAddress(CTX, Context::isolate_offset()));
const intptr_t table_offset_in_isolate =
@@ -1576,20 +1585,11 @@ void Assembler::LoadClassOfObject(Register result,
}
-void Assembler::LoadClassIndexOfObject(Register result, Register object) {
- ASSERT(RawObject::kClassTagBit == 16);
- ASSERT(RawObject::kClassTagSize == 16);
- const intptr_t class_id_offset = Object::tags_offset() +
- RawObject::kClassTagBit / kBitsPerByte;
- movzxw(result, FieldAddress(object, class_id_offset));
-}
-
-
-void Assembler::CompareClassOfObject(Register object,
- const Class& clazz,
- Register scratch) {
- LoadClassIndexOfObject(scratch, object);
- cmpl(scratch, Immediate(clazz.index()));
+void Assembler::CompareClassId(Register object,
+ intptr_t class_id,
+ Register scratch) {
+ LoadClassId(scratch, object);
+ cmpl(scratch, Immediate(class_id));
}
« no previous file with comments | « runtime/vm/assembler_ia32.h ('k') | runtime/vm/assembler_x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698