Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10458028: Fix style issues. (Closed)

Created:
8 years, 6 months ago by halyavin
Modified:
8 years, 6 months ago
Reviewers:
Mark Seaborn, eaeltsin
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-gdb.git@nacl-stub
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : more style issues #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M gdb/nacl-manifest.c View 1 3 chunks +3 lines, -3 lines 0 comments Download
M gdb/nacl-tdep.c View 1 2 4 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark Seaborn
https://chromiumcodereview.appspot.com/10458028/diff/1/gdb/nacl-manifest.c File gdb/nacl-manifest.c (right): https://chromiumcodereview.appspot.com/10458028/diff/1/gdb/nacl-manifest.c#newcode141 gdb/nacl-manifest.c:141: char* dirname; Try grepping the whole file for inconsistent ...
8 years, 6 months ago (2012-05-30 15:30:21 UTC) #1
halyavin
https://chromiumcodereview.appspot.com/10458028/diff/1/gdb/nacl-manifest.c File gdb/nacl-manifest.c (right): https://chromiumcodereview.appspot.com/10458028/diff/1/gdb/nacl-manifest.c#newcode141 gdb/nacl-manifest.c:141: char* dirname; On 2012/05/30 15:30:21, Mark Seaborn wrote: > ...
8 years, 6 months ago (2012-05-30 15:41:10 UTC) #2
halyavin
PTAL
8 years, 6 months ago (2012-05-31 08:12:06 UTC) #3
eaeltsin
8 years, 6 months ago (2012-05-31 10:12:19 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698