Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4157)

Unified Diff: chrome/browser/ui/gtk/password_generation_bubble_gtk.h

Issue 10458018: This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix a windows UI bug. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/password_generation_bubble_gtk.h
diff --git a/chrome/browser/ui/gtk/password_generation_bubble_gtk.h b/chrome/browser/ui/gtk/password_generation_bubble_gtk.h
index d82ba3e1c4d297ab6fb37cd566812b5735c5f2c5..a43db4a815458ca932f11faaa5492e0c27643999 100644
--- a/chrome/browser/ui/gtk/password_generation_bubble_gtk.h
+++ b/chrome/browser/ui/gtk/password_generation_bubble_gtk.h
@@ -8,11 +8,15 @@
#include <gtk/gtk.h>
-#include "chrome/browser/autofill/password_generator.h"
+#include "base/basictypes.h"
#include "ui/base/gtk/gtk_signal.h"
#include "ui/gfx/rect.h"
#include "webkit/forms/password_form.h"
+namespace autofill {
+class PasswordGenerator;
+}
+
namespace content {
class RenderViewHost;
}
@@ -32,6 +36,7 @@ class PasswordGenerationBubbleGtk {
GtkWidget* anchor_widget,
Profile* profile,
content::RenderViewHost* render_view_host,
+ autofill::PasswordGenerator* password_generator,
PasswordManager* password_manager);
virtual ~PasswordGenerationBubbleGtk();
@@ -52,12 +57,13 @@ class PasswordGenerationBubbleGtk {
// RenderViewHost associated with the button that spawned this bubble.
content::RenderViewHost* render_view_host_;
+ // Object that deals with generating passwords. The class won't take the
+ // ownership of it.
+ autofill::PasswordGenerator* password_generator_;
+
// PasswordManager for this tab.
PasswordManager* password_manager_;
- // Class that deals with generating passwords.
- autofill::PasswordGenerator password_generator_;
-
DISALLOW_COPY_AND_ASSIGN(PasswordGenerationBubbleGtk);
};
« no previous file with comments | « chrome/browser/ui/gtk/browser_window_gtk.cc ('k') | chrome/browser/ui/gtk/password_generation_bubble_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698