Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: chrome/browser/autofill/autofill_manager.cc

Issue 10458018: This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix a windows UI bug. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/autofill_manager.h ('k') | chrome/browser/autofill/password_generator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/autofill_manager.cc
diff --git a/chrome/browser/autofill/autofill_manager.cc b/chrome/browser/autofill/autofill_manager.cc
index 64c4db8ffb3f6ed525b8f73c691a3ec3e3c82a3e..fc6ce264c1bafadde89ab064d2ba94466fb86cc0 100644
--- a/chrome/browser/autofill/autofill_manager.cc
+++ b/chrome/browser/autofill/autofill_manager.cc
@@ -28,6 +28,7 @@
#include "chrome/browser/autofill/autofill_type.h"
#include "chrome/browser/autofill/credit_card.h"
#include "chrome/browser/autofill/form_structure.h"
+#include "chrome/browser/autofill/password_generator.h"
#include "chrome/browser/autofill/personal_data_manager.h"
#include "chrome/browser/autofill/personal_data_manager_factory.h"
#include "chrome/browser/autofill/phone_number.h"
@@ -719,13 +720,16 @@ void AutofillManager::OnHideAutofillPopup() {
void AutofillManager::OnShowPasswordGenerationPopup(
const gfx::Rect& bounds,
+ int max_length,
const webkit::forms::PasswordForm& form) {
#if defined(OS_ANDROID)
NOTIMPLEMENTED();
#else
Browser* browser = browser::FindLastActiveWithProfile(
Profile::FromBrowserContext(web_contents()->GetBrowserContext()));
- browser->window()->ShowPasswordGenerationBubble(bounds, form);
+ password_generator_.reset(new autofill::PasswordGenerator(max_length));
+ browser->window()->ShowPasswordGenerationBubble(
+ bounds, password_generator_.get(), form);
#endif // #if defined(OS_ANDROID)
}
« no previous file with comments | « chrome/browser/autofill/autofill_manager.h ('k') | chrome/browser/autofill/password_generator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698