Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3334)

Unified Diff: chrome/browser/ui/gtk/browser_window_gtk.cc

Issue 10458018: This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Some changes based on the code review. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/browser_window_gtk.cc
diff --git a/chrome/browser/ui/gtk/browser_window_gtk.cc b/chrome/browser/ui/gtk/browser_window_gtk.cc
index bfa8fe878f1b678ebf75956b22cca33e20b0baed..6acd4e1ac9600a882c8223820468258805dc5c18 100644
--- a/chrome/browser/ui/gtk/browser_window_gtk.cc
+++ b/chrome/browser/ui/gtk/browser_window_gtk.cc
@@ -1290,7 +1290,9 @@ void BrowserWindowGtk::ShowAvatarBubbleFromAvatarButton() {
titlebar_->avatar_button()->ShowAvatarBubble();
}
-void BrowserWindowGtk::ShowPasswordGenerationBubble(const gfx::Rect& rect) {
+void BrowserWindowGtk::ShowPasswordGenerationBubble(
+ const gfx::Rect& rect,
+ const autofill::PasswordGenerator& password_generator) {
WebContents* web_contents = browser_->GetSelectedWebContents();
if (!web_contents || !web_contents->GetContentNativeView()) {
return;
@@ -1299,7 +1301,8 @@ void BrowserWindowGtk::ShowPasswordGenerationBubble(const gfx::Rect& rect) {
new PasswordGenerationBubbleGtk(rect,
web_contents->GetContentNativeView(),
browser()->profile(),
- web_contents->GetRenderViewHost());
+ web_contents->GetRenderViewHost(),
+ password_generator);
}
void BrowserWindowGtk::ConfirmBrowserCloseWithPendingDownloads() {

Powered by Google App Engine
This is Rietveld 408576698