Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: lib/compiler/implementation/tree/nodes.dart

Issue 10456080: Remove printDebugInfo from Unparser (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address Anton's comments. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/tests/leg/resolver_test.dart ('k') | lib/compiler/implementation/tree/unparser.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/tree/nodes.dart
diff --git a/lib/compiler/implementation/tree/nodes.dart b/lib/compiler/implementation/tree/nodes.dart
index f5aa5adcded14326fc9d60e49603f1ca1b960fd2..070e4fcb658879d0fcd87f4ca1bb3716d3c2cce3 100644
--- a/lib/compiler/implementation/tree/nodes.dart
+++ b/lib/compiler/implementation/tree/nodes.dart
@@ -90,14 +90,15 @@ class Node implements Hashable {
abstract visitChildren(Visitor visitor);
- toString() => unparse(false);
-
- toDebugString() => unparse(true);
ahe 2012/06/08 07:43:36 I assumed we would keep toDebugString, but use you
Roman 2012/06/08 08:13:12 Yes, that was the original plan. But then I saw th
ahe 2012/06/08 08:16:56 Yes. We often use the method for debugging by "pri
Roman 2012/06/08 12:33:33 I see. Got back toDebugString() that returns node
+ /**
+ * Returns this node unparsed to Dart source string.
+ */
+ toString() => unparse();
String getObjectDescription() => super.toString();
- String unparse(bool printDebugInfo) {
- Unparser unparser = new Unparser(printDebugInfo);
+ String unparse() {
+ Unparser unparser = new Unparser();
try {
return unparser.unparse(this);
} catch (var e, var trace) {
« no previous file with comments | « frog/tests/leg/resolver_test.dart ('k') | lib/compiler/implementation/tree/unparser.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698