Remove printDebugInfo from Unparser

lib/compiler/implementation/tree/nodes.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 interface Visitor<R> {
   R visitBlock(Block node);
   R visitBreakStatement(BreakStatement node);
   R visitCascade(Cascade node);
   R visitCascadeReceiver(CascadeReceiver node);
   R visitCaseMatch(CaseMatch node);
@@ skipping 72 matching lines @@
   static int _HASH_COUNTER = 0;
 
   Node() : _hashCode = ++_HASH_COUNTER;
 
   hashCode() => _hashCode;
 
   abstract accept(Visitor visitor);
 
   abstract visitChildren(Visitor visitor);
 
+  /**
+   * Returns this node unparsed to Dart source string.
+   */
   toString() => unparse(false);
 
+  /**
+   * Returns Xml-like tree representation of this node
+   * and Dart source string of this node.
+   */
   toDebugString() => unparse(true);
 
   String getObjectDescription() => super.toString();
 
   String unparse(bool printDebugInfo) {

[Anton Muhin, 2012/06/05 09:35:19]

do we really need to bundle both?

I'd rather have prettyprint and unparse methods.

[Roman, 2012/06/05 11:09:07]

I'd rather too, but there was a usage in tests that could benefit from printing
both.
However, I don't think that's important, there is only one place where
"toDebugString" is used (tests), so I just removed that thing.

-    Unparser unparser = new Unparser(printDebugInfo);
+    StringBuffer sb = new StringBuffer();
+    if (printDebugInfo) {
+      PrettyPrinter prettyPrinter = new PrettyPrinter();
+      sb.add(prettyPrinter.prettyprint(this));
+      sb.add('\n');
+    }
+    Unparser unparser = new Unparser();
     try {
-      return unparser.unparse(this);
+      sb.add(unparser.unparse(this));
+      return sb.toString();
     } catch (var e, var trace) {
       print(trace);
       return '<<unparse error: ${getObjectDescription()}: ${unparser.sb}>>';
     }
   }
 
   abstract Token getBeginToken();
 
   abstract Token getEndToken();
 
@@ skipping 1587 matching lines @@
  * argument).
  *
  * TODO(ahe): This method is controversial, the team needs to discuss
  * if top-level methods are acceptable and what naming conventions to
  * use.
  */
 initializerDo(Node node, f(Node node)) {
   SendSet send = node.asSendSet();
   if (send !== null) return f(send.arguments.head);
 }