Issue 10456055: Stop using "+chromeos(...)" in an XKB layout name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10456055: Stop using "+chromeos(...)" in an XKB layout name. (Closed)

Created:
8 years, 6 months ago by Yusuke Sato

Modified:
8 years, 6 months ago

Reviewers:
Zachary Kuznia

CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Stop using "+chromeos(...)" in an XKB layout name. This CL requires Chrome OS 2375.0.0 or newer. BUG=chromium-os:31324 TEST=ran unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140274

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -71 lines)			Patch
M	chrome/browser/chromeos/input_method/mock_xkeyboard.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/mock_xkeyboard.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/xkeyboard.h	View	2 chunks	+3 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/xkeyboard.cc	View	6 chunks	+30 lines, -37 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/xkeyboard_unittest.cc	View	1 chunk	+15 lines, -18 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10456055/1

8 years, 6 months ago (2012-06-04 10:53:17 UTC) #3

Change committed as 140274

Expand Messages | Collapse Messages