Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 10456043: Disable showing GSC when in KioskMode. (Closed)

Created:
8 years, 6 months ago by rkc
Modified:
8 years, 6 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Disable showing GSC when in KioskMode. If the startup URL is not set, even in kiosk mode, the GSC would show; this CL fixes that. R=dpolukhin@chromium.org,nkostylev@chromium.org BUG=129682 TEST=Tested on a base image and verified that the GSC doesn't show up anymore. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139683

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 chunk +10 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rkc
8 years, 6 months ago (2012-05-30 23:28:41 UTC) #1
DaveMoore
lgtm
8 years, 6 months ago (2012-05-30 23:31:45 UTC) #2
Dmitry Polukhin
LGTM, thanks for fixing this! It was surprise for me that we have 2 paths ...
8 years, 6 months ago (2012-05-31 09:00:42 UTC) #3
Nikita (slow)
8 years, 6 months ago (2012-05-31 15:22:39 UTC) #4
On 2012/05/31 09:00:42, Dmitry Polukhin wrote:
> LGTM, thanks for fixing this!
> 
> It was surprise for me that we have 2 paths to show GSG. This code needs to be
> refactored to have only one path that will show GSG or release notes.

Agree, I'll work on that when I'll have free cycles.

Powered by Google App Engine
This is Rietveld 408576698