Issue 10456043: Disable showing GSC when in KioskMode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10456043: Disable showing GSC when in KioskMode. (Closed)

Created:
8 years, 6 months ago by rkc

Modified:
8 years, 6 months ago

Reviewers:
Dmitry Polukhin, Nikita (slow), DaveMoore

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disable showing GSC when in KioskMode. If the startup URL is not set, even in kiosk mode, the GSC would show; this CL fixes that. R=dpolukhin@chromium.org,nkostylev@chromium.org BUG=129682 TEST=Tested on a base image and verified that the GSC doesn't show up anymore. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139683

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -9 lines)			Patch
	M	chrome/browser/chromeos/login/existing_user_controller.cc	View		1 chunk	+10 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dmitry Polukhin

LGTM, thanks for fixing this! It was surprise for me that we have 2 paths ...

8 years, 6 months ago (2012-05-31 09:00:42 UTC) #3

Nikita (slow)

8 years, 6 months ago (2012-05-31 15:22:39 UTC) #4

On 2012/05/31 09:00:42, Dmitry Polukhin wrote:
> LGTM, thanks for fixing this!
> 
> It was surprise for me that we have 2 paths to show GSG. This code needs to be
> refactored to have only one path that will show GSG or release notes.

Agree, I'll work on that when I'll have free cycles.

Expand Messages | Collapse Messages