Added release_extra_cflags only to the target compiles.

Added release_extra_cflags only to the target compiles.

Without this CL, the gyp define release_extra_cflags is applied to both host and
target compiles. With this CL, the gyp define is only applied to the target
compiles.

BUG=v8:2157
TEST=gyp_chromium with extra flags. Made sure that the target mk files like
v8_shell.host.mk did not have the flags while v8_nosnapshot.target.mk had the
flags.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139909

[asharif1, 2012-05-30 17:34:12]

+reviewer: jkummerow.

Please take a look.

[Mark Mentovai, 2012-05-30 17:57:34]

Why?

What about debug?

[asharif1, 2012-05-30 18:03:57]

On 2012/05/30 17:57:34, Mark Mentovai wrote:
> Why?

It's bad to add the same flags to the host and target for many reasons, one of
which is here: http://code.google.com/p/v8/issues/detail?id=2157

There are other reasons too: what if the flag is an ARM-specific flag and our
host is x86?

> 
> What about debug?

I'll do the same for the debug flags and re-upload this CL.

[asharif1, 2012-05-30 18:08:20]

On 2012/05/30 18:03:57, asharif1 wrote:
> On 2012/05/30 17:57:34, Mark Mentovai wrote:
> > Why?
> 
> It's bad to add the same flags to the host and target for many reasons, one of
> which is here: http://code.google.com/p/v8/issues/detail?id=2157
> 
> There are other reasons too: what if the flag is an ARM-specific flag and our
> host is x86?
> 
> > 
> > What about debug?
> 
> I'll do the same for the debug flags and re-upload this CL.

Done. Re-review please.

[Jakob Kummerow, 2012-05-30 20:12:02]

LGTM with a nit.

You could have avoided repetition of the "'conditions': [" line by putting a
target_conditions section into the existing 'conditions': [ ['OS=="linux"',
{...}] ] block, but I don't mind either way.

http://codereview.chromium.org/10456020/diff/10003/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/10456020/diff/10003/build/common.gypi#newcode1837
build/common.gypi:1837: }],],
nit: the last "]," goes on its own line.

[asharif1, 2012-05-30 21:58:57]

On 2012/05/30 20:12:02, Jakob wrote:
> LGTM with a nit.
> 
> You could have avoided repetition of the "'conditions': [" line by putting a
> target_conditions section into the existing 'conditions': [ ['OS=="linux"',
> {...}] ] block, but I don't mind either way.
> 
> http://codereview.chromium.org/10456020/diff/10003/build/common.gypi
> File build/common.gypi (right):
> 
>
http://codereview.chromium.org/10456020/diff/10003/build/common.gypi#newcode1837
> build/common.gypi:1837: }],],
> nit: the last "]," goes on its own line.

Jakob, please take another look.

[Jakob Kummerow, 2012-05-31 08:15:34]

lgtm

[commit-bot: I haz the power, 2012-05-31 17:47:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asharif@chromium.org/10456020/11002

[commit-bot: I haz the power, 2012-05-31 23:08:03]

Change committed as 139909