[Android] Split the address parser from AddressDetector for WebView use.

[Android] Split the address parser from AddressDetector for WebView use.

Split the address parser inside AddressDetector into a separate file outside
the renderer folder. This is done in order to provide support for Java's
WebView.findAddress using the new address parser while preventing layering
violations in Chromium (WebView should not access content/renderer).


BUG=125390
TEST=address_parser_unittest.cc

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139597

[Leandro Graciá Gil, 2012-05-28 17:59:49]

piman: split of the address parser. This is the content/renderer/android and the
content/common/android changes.
jam: changes in the content/ gyp files and the folder where the new address
parser is placed.

Thanks!

Btw, who should I add in the future as an owner for the changes in
content/common/android? (if we stick with that folder, which should have more
android changes than this).

[jam, 2012-05-29 19:19:04]

lgtm

[piman, 2012-05-29 19:53:25]

https://chromiumcodereview.appspot.com/10456007/diff/1/content/common/android...
File content/common/android/address_parser.h (right):

https://chromiumcodereview.appspot.com/10456007/diff/1/content/common/android...
content/common/android/address_parser.h:18: class AddressParser {
So, this class has no field or non-static method, and AFAICT isn't instantiated.
Could it be made into a namespace instead? That's what the style guide
recommends in that case.

[Leandro Graciá Gil, 2012-05-30 18:19:56]

http://codereview.chromium.org/10456007/diff/1/content/common/android/address...
File content/common/android/address_parser.h (right):

http://codereview.chromium.org/10456007/diff/1/content/common/android/address...
content/common/android/address_parser.h:18: class AddressParser {
On 2012/05/29 19:53:26, piman wrote:
> So, this class has no field or non-static method, and AFAICT isn't
instantiated.
> Could it be made into a namespace instead? That's what the style guide
> recommends in that case.

Done.

[piman, 2012-05-30 18:43:46]

LGTM, thanks

[Leandro Graciá Gil, 2012-05-30 18:55:33]

On 2012/05/30 18:43:46, piman wrote:
> LGTM, thanks

Np. Thanks for the suggestion and for the review.