Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: chrome/common/extensions/api/app_window.idl

Issue 10456003: Make 'options' and callback arg to chrome.appWindow.create optional. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // File-level comment to appease parser. Eventually this will not be necessary. 5 // File-level comment to appease parser. Eventually this will not be necessary.
6 6
7 [nodoc] namespace appWindow { 7 [nodoc] namespace appWindow {
8 dictionary CreateWindowOptions { 8 dictionary CreateWindowOptions {
9 // Width of the window. 9 // Width of the window.
10 long? width; 10 long? width;
11 11
12 // Height of the window. 12 // Height of the window.
13 long? height; 13 long? height;
14 14
15 long? left; 15 long? left;
16 long? top; 16 long? top;
17 17
18 // Window type: 'panel' or 'shell' (defaults to 'shell') 18 // Window type: 'panel' or 'shell' (defaults to 'shell')
19 DOMString? type; 19 DOMString? type;
20 20
21 // Frame type: 'custom' or 'chrome' (defaults to 'chrome') 21 // Frame type: 'custom' or 'chrome' (defaults to 'chrome')
22 DOMString? frame; 22 DOMString? frame;
23 }; 23 };
24 24
25 callback CreateWindowCallback = void (long view_id); 25 callback CreateWindowCallback = void (long view_id);
26 26
27 interface Functions { 27 interface Functions {
28 static void create(DOMString url, 28 static void create(DOMString url,
29 CreateWindowOptions options, 29 optional CreateWindowOptions options,
30 CreateWindowCallback callback); 30 CreateWindowCallback callback);
asargent_no_longer_on_chrome 2012/05/28 16:22:50 any reason not to have the create callback optiona
jeremya 2012/05/28 23:11:38 Seems not :) Done.
31 }; 31 };
32 }; 32 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698