Issue 10455005: TraversableMap only dependent on DescriptorArray

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10455005: TraversableMap only dependent on DescriptorArray (Closed)

Created:
8 years, 7 months ago by Toon Verwaest

Modified:
8 years, 6 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

TraversableMap only dependent on DescriptorArray This is the first step towards merging the ContentArray into the DescriptorArray, (hence reclaiming 3 words per descriptor array). Committed: https://code.google.com/p/v8/source/detail?r=11682

Patch Set 1 #

Patch Set 2 : fixing iteration bug that made tests run slow #

Patch Set 3 : Removed assert since it increased brittleness. It assumed that the map transition iterator was neve… #

Total comments: 2

Patch Set 4 : fixing indent #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/objects.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

The added patch fixes the iteration bug introduced in the second patch of the original ...

8 years, 7 months ago (2012-05-25 16:28:08 UTC) #1

Michael Starzinger

8 years, 6 months ago (2012-05-30 13:28:55 UTC) #2

LGTM (if one nit is addressed).

https://chromiumcodereview.appspot.com/10455005/diff/6001/src/objects.cc
File src/objects.cc (right):

https://chromiumcodereview.appspot.com/10455005/diff/6001/src/objects.cc#newc...
src/objects.cc:5130: *DescriptorArrayHeader() = Smi::FromInt(raw_index);
Indentation seems off.

https://chromiumcodereview.appspot.com/10455005/diff/6001/src/objects.cc#newc...
src/objects.cc:5306: }
Just out of curiosity: What is the difference between whether we iterate
prototype transitions or descriptor transitions first?

Expand Messages | Collapse Messages