Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 10454109: Validation of write access to chrome profile. (Closed)

Created:
8 years, 6 months ago by Vitaly Buka (NO REVIEWS)
Modified:
8 years, 6 months ago
Reviewers:
gene
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Validation of write access to chrome profile. BUG=125026 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140110

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -12 lines) Patch
M cloud_print/service/win/cloud_print_service.cc View 1 2 9 chunks +72 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Vitaly Buka (NO REVIEWS)
8 years, 6 months ago (2012-06-01 05:28:31 UTC) #1
Vitaly Buka (NO REVIEWS)
8 years, 6 months ago (2012-06-01 17:25:17 UTC) #2
gene
lgtm with nits: https://chromiumcodereview.appspot.com/10454109/diff/1/cloud_print/service/win/cloud_print_service.cc File cloud_print/service/win/cloud_print_service.cc (right): https://chromiumcodereview.appspot.com/10454109/diff/1/cloud_print/service/win/cloud_print_service.cc#newcode149 cloud_print/service/win/cloud_print_service.cc:149: ATL::CTokenGroups(), put 2 past params to ...
8 years, 6 months ago (2012-06-01 17:39:33 UTC) #3
Vitaly Buka (NO REVIEWS)
https://chromiumcodereview.appspot.com/10454109/diff/1/cloud_print/service/win/cloud_print_service.cc File cloud_print/service/win/cloud_print_service.cc (right): https://chromiumcodereview.appspot.com/10454109/diff/1/cloud_print/service/win/cloud_print_service.cc#newcode149 cloud_print/service/win/cloud_print_service.cc:149: ATL::CTokenGroups(), On 2012/06/01 17:39:33, gene wrote: > put 2 ...
8 years, 6 months ago (2012-06-01 18:02:55 UTC) #4
gene
lgtm
8 years, 6 months ago (2012-06-01 18:05:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10454109/9003
8 years, 6 months ago (2012-06-01 18:33:17 UTC) #6
commit-bot: I haz the power
8 years, 6 months ago (2012-06-01 22:22:45 UTC) #7
Change committed as 140110

Powered by Google App Engine
This is Rietveld 408576698