Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 10454088: Automatically update submodule config entries on sync. (Closed)

Created:
8 years, 6 months ago by szager1
Modified:
8 years, 6 months ago
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel
Visibility:
Public.

Description

Automatically update submodule config entries on sync. The effect of this is to preserve the behavior of `git status`, i.e., only changes in the top-level repository will be reported. Updated test expectations; I have no idea what I'm doing. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140396

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M gclient_scm.py View 1 2 3 4 chunks +18 lines, -0 lines 0 comments Download
M tests/gclient_scm_test.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
szager1
8 years, 6 months ago (2012-05-31 01:32:51 UTC) #1
M-A Ruel
https://chromiumcodereview.appspot.com/10454088/diff/1/tests/gclient_smoketest.py File tests/gclient_smoketest.py (right): https://chromiumcodereview.appspot.com/10454088/diff/1/tests/gclient_smoketest.py#newcode142 tests/gclient_smoketest.py:142: self.assertEquals(len(results), len(items), (stdout, items, len(items), len(results))) please wrap https://chromiumcodereview.appspot.com/10454088/diff/1/tests/gclient_smoketest.py#newcode800 ...
8 years, 6 months ago (2012-05-31 01:35:51 UTC) #2
szager1
https://chromiumcodereview.appspot.com/10454088/diff/1/tests/gclient_smoketest.py File tests/gclient_smoketest.py (right): https://chromiumcodereview.appspot.com/10454088/diff/1/tests/gclient_smoketest.py#newcode142 tests/gclient_smoketest.py:142: self.assertEquals(len(results), len(items), (stdout, items, len(items), len(results))) On 2012/05/31 01:35:52, ...
8 years, 6 months ago (2012-05-31 06:39:44 UTC) #3
cmp
lgtm, but you should wait for maruel's or nsylvain's lgtm, too :)
8 years, 6 months ago (2012-05-31 20:43:06 UTC) #4
nsylvain
I'm OK with the change although I dont think I know this code enough to ...
8 years, 6 months ago (2012-06-01 01:29:09 UTC) #5
M-A Ruel
lgtm https://chromiumcodereview.appspot.com/10454088/diff/1/tests/gclient_smoketest.py File tests/gclient_smoketest.py (right): https://chromiumcodereview.appspot.com/10454088/diff/1/tests/gclient_smoketest.py#newcode800 tests/gclient_smoketest.py:800: ['running', ('running', self.root_dir + '/src'), On 2012/05/31 06:39:45, ...
8 years, 6 months ago (2012-06-01 01:57:50 UTC) #6
szager1
FYI: playing with this a bit, I saw that the `git submodule` calls produce way ...
8 years, 6 months ago (2012-06-04 22:06:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/10454088/13001
8 years, 6 months ago (2012-06-04 22:06:26 UTC) #8
commit-bot: I haz the power
8 years, 6 months ago (2012-06-04 22:13:57 UTC) #9
Change committed as 140396

Powered by Google App Engine
This is Rietveld 408576698