Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3951)

Unified Diff: chrome/browser/ui/webui/about_ui.cc

Issue 10454086: Histograms - Support histograms for Plugins, GPU (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/about_ui.cc
===================================================================
--- chrome/browser/ui/webui/about_ui.cc (revision 140625)
+++ chrome/browser/ui/webui/about_ui.cc (working copy)
@@ -18,7 +18,6 @@
#include "base/json/json_writer.h"
#include "base/memory/ref_counted_memory.h"
#include "base/memory/singleton.h"
-#include "base/metrics/histogram.h"
#include "base/metrics/stats_table.h"
#include "base/path_service.h"
#include "base/string_number_conversions.h"
@@ -33,7 +32,6 @@
#include "chrome/browser/browser_process.h"
#include "chrome/browser/defaults.h"
#include "chrome/browser/memory_details.h"
-#include "chrome/browser/metrics/histogram_synchronizer.h"
#include "chrome/browser/net/predictor.h"
#include "chrome/browser/net/url_fixer_upper.h"
#include "chrome/browser/plugin_prefs.h"
@@ -798,34 +796,6 @@
DISALLOW_COPY_AND_ASSIGN(AboutDnsHandler);
};
-std::string AboutHistograms(const std::string& query) {
- TimeDelta wait_time = TimeDelta::FromMilliseconds(10000);
-
-#ifndef NDEBUG
- base::StatisticsRecorder::CollectHistogramStats("Browser");
jar (doing other things) 2012/07/09 23:04:12 Please modify the XML file to show these histogram
ramant (doing other things) 2012/07/11 23:52:54 Submitting a separate CL for XML changes. Done.
-#endif
-
- HistogramSynchronizer* current_synchronizer =
- HistogramSynchronizer::CurrentSynchronizer();
- DCHECK(current_synchronizer != NULL);
- current_synchronizer->FetchRendererHistogramsSynchronously(wait_time);
-
- std::string unescaped_query;
- std::string unescaped_title("About Histograms");
- if (!query.empty()) {
- unescaped_query = net::UnescapeURLComponent(query,
- net::UnescapeRule::NORMAL);
- unescaped_title += " - " + unescaped_query;
- }
-
- std::string data;
- AppendHeader(&data, 0, unescaped_title);
- AppendBody(&data);
- base::StatisticsRecorder::WriteHTMLGraph(unescaped_query, &data);
- AppendFooter(&data);
- return data;
-}
-
void FinishMemoryDataRequest(const std::string& path,
AboutUIHTMLSource* source,
int request_id) {
@@ -1404,8 +1374,6 @@
} else if (host == chrome::kChromeUIDNSHost) {
AboutDnsHandler::Start(this, request_id);
return;
- } else if (host == chrome::kChromeUIHistogramsHost) {
- response = AboutHistograms(path);
#if defined(OS_LINUX) || defined(OS_OPENBSD)
} else if (host == chrome::kChromeUILinuxProxyConfigHost) {
response = AboutLinuxProxyConfig();

Powered by Google App Engine
This is Rietveld 408576698