Issue 10454064: ui: Use utility functions from base/win throughout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10454064: ui: Use utility functions from base/win throughout. (Closed)

Created:
8 years, 6 months ago by tfarina

Modified:
8 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, James Su, ben+watch_chromium.org, penghuang+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ui: Use utility functions from base/win throughout. This makes the code easier to read and understand. BUG=128242 R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140239

Patch Set 2 : use GetModifiersFromKeyState() #

Total comments: 1

Patch Set 3 : include win_util.h #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -13 lines)			Patch
M	ui/base/win/events_win.cc	View	1 2	2 chunks	+4 lines, -3 lines	0 comments	Download
M	ui/views/ime/input_method_win.cc	View	1	2 chunks	+3 lines, -6 lines	0 comments	Download
M	ui/views/widget/native_widget_win.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tfarina

http://codereview.chromium.org/10454064/diff/4001/ui/base/win/events_win.cc File ui/base/win/events_win.cc (right): http://codereview.chromium.org/10454064/diff/4001/ui/base/win/events_win.cc#newcode87 ui/base/win/events_win.cc:87: flags |= base::win::IsAltPressed() ? ui::EF_ALT_DOWN : ui::EF_NONE; this code ...

8 years, 6 months ago (2012-05-30 00:04:29 UTC) #1

lgtm