Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 10454058: Remove PPB_Transport_Dev API. (Closed)

Created:
8 years, 6 months ago by Sergey Ulanov
Modified:
8 years, 6 months ago
Reviewers:
jamesr, brettw
CC:
chromium-reviews, jochen+watch-content_chromium.org, jam, yzshen+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org, Wez
Visibility:
Public.

Description

Remove PPB_Transport_Dev API. BUG=109630 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139660

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1676 lines) Patch
M build/common.gypi View 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/test/ui/ppapi_uitest.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_renderer.gypi View 2 chunks +14 lines, -18 lines 0 comments Download
M content/content_tests.gypi View 1 2 chunks +5 lines, -9 lines 0 comments Download
M content/renderer/p2p/port_allocator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +2 lines, -7 lines 0 comments Download
D ppapi/api/dev/ppb_transport_dev.idl View 1 chunk +0 lines, -183 lines 0 comments Download
D ppapi/c/dev/ppb_transport_dev.h View 1 chunk +0 lines, -186 lines 0 comments Download
D ppapi/cpp/dev/transport_dev.h View 1 chunk +0 lines, -37 lines 0 comments Download
D ppapi/cpp/dev/transport_dev.cc View 1 chunk +0 lines, -94 lines 0 comments Download
M ppapi/ppapi_proxy_untrusted.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/ppapi_shared.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/ppapi_sources.gypi View 1 chunk +0 lines, -13 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ppapi/shared_impl/resource.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/tests/all_c_includes.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/tests/all_cpp_includes.h View 1 chunk +0 lines, -1 line 0 comments Download
D ppapi/tests/test_transport.h View 1 chunk +0 lines, -51 lines 0 comments Download
D ppapi/tests/test_transport.cc View 1 chunk +0 lines, -373 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev.h View 2 chunks +0 lines, -3 lines 0 comments Download
D ppapi/thunk/ppb_transport_api.h View 1 chunk +0 lines, -33 lines 0 comments Download
D ppapi/thunk/ppb_transport_thunk.cc View 1 chunk +0 lines, -112 lines 0 comments Download
M ppapi/thunk/resource_creation_api.h View 2 chunks +0 lines, -4 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 chunk +0 lines, -1 line 0 comments Download
D webkit/plugins/ppapi/ppb_transport_impl.h View 1 chunk +0 lines, -82 lines 0 comments Download
D webkit/plugins/ppapi/ppb_transport_impl.cc View 1 chunk +0 lines, -404 lines 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.cc View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Sergey Ulanov
8 years, 6 months ago (2012-05-29 21:32:31 UTC) #1
brettw
Woot! LGTM.
8 years, 6 months ago (2012-05-30 03:49:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10454058/1
8 years, 6 months ago (2012-05-30 04:54:23 UTC) #3
commit-bot: I haz the power
Presubmit check for 10454058-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 6 months ago (2012-05-30 04:55:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10454058/1
8 years, 6 months ago (2012-05-30 17:42:01 UTC) #5
commit-bot: I haz the power
Presubmit check for 10454058-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 6 months ago (2012-05-30 17:42:29 UTC) #6
Sergey Ulanov
+jamesr for webkit/glue
8 years, 6 months ago (2012-05-30 21:31:06 UTC) #7
brettw
I think it's OK if you TBR the webkit_glue changes
8 years, 6 months ago (2012-05-30 21:33:18 UTC) #8
jamesr
lgtm I agree it would be fine to TBR this sort of change in the ...
8 years, 6 months ago (2012-05-30 21:49:12 UTC) #9
jamesr
8 years, 6 months ago (2012-05-30 21:49:36 UTC) #10
On 2012/05/30 21:49:12, jamesr wrote:
> lgtm
> 
> I agree it would be fine to TBR this sort of change in the future

The webkit_glue parts of the change, that is.  I'm not suggesting you TBR the
whole patch for things like this :)

Powered by Google App Engine
This is Rietveld 408576698