Validate that all instructions dominate their inputs. And fix a bug where that did not happen.

lib/compiler/implementation/ssa/closure.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class ClosureFieldElement extends Element {
   ClosureFieldElement(SourceString name, ClassElement enclosing)
       : super(name, ElementKind.FIELD, enclosing);
 
   bool isInstanceMember() => true;
   bool isAssignable() => false;
@@ skipping 418 matching lines @@
     }
   }
 
   visitFunctionDeclaration(FunctionDeclaration node) {
     node.visitChildren(this);
     declareLocal(elements[node]);
   }
 
   visitTryStatement(TryStatement node) {
     // TODO(ngeoffray): implement finer grain state.
+    bool oldInTryCatchOrFinally = inTryCatchOrFinally;

[Lasse Reichstein Nielsen, 2012/05/30 09:35:14]

Odd name. Could it be just "inTryStatement" since the catch and finally blocks
are part of the "try" statement?

[ngeoffray, 2012/05/30 10:19:07]

Done.

     inTryCatchOrFinally = true;
     node.visitChildren(this);
-    inTryCatchOrFinally = false;
+    inTryCatchOrFinally = oldInTryCatchOrFinally;
   }
 }