Issue 10454039: Fix regyp on android_test try bot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10454039: Fix regyp on android_test try bot. (Closed)

Created:
8 years, 7 months ago by nilesh

Modified:
8 years, 7 months ago

Reviewers:
John Grabowski, Xianzhu

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix regyp on android_test try bot. BUG=125059 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139155

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	build/android/buildbot_functions.sh	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

LGTM http://codereview.chromium.org/10454039/diff/1/build/android/buildbot_functions.sh File build/android/buildbot_functions.sh (right): http://codereview.chromium.org/10454039/diff/1/build/android/buildbot_functions.sh#newcode200 build/android/buildbot_functions.sh:200: bb_setup_goma_internal This only makes sense to me if ...

8 years, 7 months ago (2012-05-25 22:09:31 UTC) #2

commit-bot: I haz the power

8 years, 7 months ago (2012-05-25 22:33:34 UTC) #3

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10454039/1

Expand Messages | Collapse Messages