Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 10454038: Fixing make generator handling of multiple actions in a dependent target. (Closed)

Created:
8 years, 7 months ago by bradn
Modified:
8 years, 6 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com, Evan Martin
Visibility:
Public.

Description

Fixing make generator handling of multiple actions in a dependent target. Multiple actions in a single none target fail to all depend correctly on the stamps from all the targets that they are in depend on. test/actions-multiple has been enhanced to cover this case. BUG=https://code.google.com/p/chromium/issues/detail?id=129814 TEST=test/actions-multiple R=thakis@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1403

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -9 lines) Patch
M pylib/gyp/generator/make.py View 1 4 chunks +6 lines, -8 lines 0 comments Download
M test/actions-multiple/gyptest-all.py View 1 2 3 3 chunks +31 lines, -1 line 0 comments Download
M test/actions-multiple/src/actions.gyp View 1 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bradn
8 years, 7 months ago (2012-05-25 21:35:58 UTC) #1
Nico
http://codereview.chromium.org/10454038/diff/1/test/actions-multiple/gyptest-all.py File test/actions-multiple/gyptest-all.py (right): http://codereview.chromium.org/10454038/diff/1/test/actions-multiple/gyptest-all.py#newcode22 test/actions-multiple/gyptest-all.py:22: # This is only relevant to the make generator. ...
8 years, 6 months ago (2012-05-28 16:43:53 UTC) #2
bradn
PTAL http://codereview.chromium.org/10454038/diff/1/test/actions-multiple/gyptest-all.py File test/actions-multiple/gyptest-all.py (right): http://codereview.chromium.org/10454038/diff/1/test/actions-multiple/gyptest-all.py#newcode22 test/actions-multiple/gyptest-all.py:22: # This is only relevant to the make ...
8 years, 6 months ago (2012-05-29 21:21:47 UTC) #3
Nico
I think this is fine. http://codereview.chromium.org/10454038/diff/6/test/actions-multiple/gyptest-all.py File test/actions-multiple/gyptest-all.py (right): http://codereview.chromium.org/10454038/diff/6/test/actions-multiple/gyptest-all.py#newcode22 test/actions-multiple/gyptest-all.py:22: # depend on another ...
8 years, 6 months ago (2012-05-29 21:33:08 UTC) #4
bradn
PTAL http://codereview.chromium.org/10454038/diff/6/test/actions-multiple/gyptest-all.py File test/actions-multiple/gyptest-all.py (right): http://codereview.chromium.org/10454038/diff/6/test/actions-multiple/gyptest-all.py#newcode22 test/actions-multiple/gyptest-all.py:22: # depend on another 'none' target cause depended ...
8 years, 6 months ago (2012-05-29 21:44:26 UTC) #5
Nico
8 years, 6 months ago (2012-05-29 21:48:06 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698