runtime/vm/disassembler_ia32.cc - Issue 10453110: Implement optimized unary ops for ia32 as well. Fix a crash in disassembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/disassembler_ia32.cc

Issue 10453110: Implement optimized unary ops for ia32 as well. Fix a crash in disassembler. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/disassembler_ia32.cc

===================================================================

--- runtime/vm/disassembler_ia32.cc (revision 8181)

+++ runtime/vm/disassembler_ia32.cc (working copy)

@@ -430,10 +430,14 @@

const Code& code = Code::Handle(Code::LookupCode(addr));

if (!code.IsNull() && (code.EntryPoint() == addr)) {

const Function& function = Function::Handle(code.function());

- const char* name_of_function = function.ToFullyQualifiedCString();

- Print(" [");

- Print(name_of_function);

- Print("]");

+ if (function.IsNull()) {

+ Print(" [ stub ]");

+ } else {

+ const char* name_of_function = function.ToFullyQualifiedCString();

+ Print(" [");

+ Print(name_of_function);

+ Print("]");

+ }

}

« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_ia32.h » ('j') | runtime/vm/intermediate_language_ia32.cc » ('J')