Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1786)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc

Issue 10453101: Convert most of the rest of chrome to ImageSkia (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc b/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc
index 371c6e93bcd7633703daebd6c48f822b6a44c71e..882479c71ddaf16d9b05248d9587815535fe42ef 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc
@@ -436,7 +436,7 @@ void BookmarkMenuDelegate::BuildMenuForPermanentNode(
int id = *next_menu_id;
(*next_menu_id)++;
ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
- SkBitmap* folder_icon = rb.GetBitmapNamed(IDR_BOOKMARK_BAR_FOLDER);
+ gfx::ImageSkia* folder_icon = rb.GetImageSkiaNamed(IDR_BOOKMARK_BAR_FOLDER);
MenuItemView* submenu = menu->AppendSubMenuWithIcon(
id, node->GetTitle(), *folder_icon);
BuildMenu(node, 0, submenu, next_menu_id);
@@ -455,14 +455,16 @@ void BookmarkMenuDelegate::BuildMenu(const BookmarkNode* parent,
(*next_menu_id)++;
if (node->is_url()) {
- SkBitmap icon = profile_->GetBookmarkModel()->GetFavicon(node);
+ gfx::ImageSkia icon = gfx::ImageSkia(
+ profile_->GetBookmarkModel()->GetFavicon(node));
if (icon.width() == 0) {
- icon = *rb.GetBitmapNamed(IDR_DEFAULT_FAVICON);
+ icon = *rb.GetImageSkiaNamed(IDR_DEFAULT_FAVICON);
}
menu->AppendMenuItemWithIcon(id, node->GetTitle(), icon);
node_to_menu_id_map_[node] = id;
} else if (node->is_folder()) {
- SkBitmap* folder_icon = rb.GetBitmapNamed(IDR_BOOKMARK_BAR_FOLDER);
+ gfx::ImageSkia* folder_icon =
+ rb.GetImageSkiaNamed(IDR_BOOKMARK_BAR_FOLDER);
MenuItemView* submenu = menu->AppendSubMenuWithIcon(
id, node->GetTitle(), *folder_icon);
node_to_menu_id_map_[node] = id;
« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc ('k') | chrome/browser/ui/views/constrained_window_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698