Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 10453101: Convert most of the rest of chrome to ImageSkia (Closed)

Created:
8 years, 6 months ago by pkotwicz
Modified:
8 years, 6 months ago
Reviewers:
Satish, sky
CC:
chromium-reviews, asanka, mihaip-chromium-reviews_chromium.org, jennb, Aaron Boodman, yoshiki+watch_chromium.org, kkania, Dmitry Titov, dcheng, Randy Smith (Not in Mondays), feature-media-reviews_chromium.org, Satish, robertshield, jianli, rdsmith+dwatch_chromium.org, Andrei
Visibility:
Public.

Description

Converted the rest of chrome except for extensions and favicons to user ImageSkia Used same conversion script as 10437006 Modified the following files afterwards: 1 chrome/browser/background/background_application_list_model.cc 2 chrome/browser/extensions/extension_install_ui.cc 3 chrome/browser/extensions/extension_install_ui.h 4 chrome/browser/speech/speech_recognition_bubble.cc 5 chrome/browser/speech/speech_recognition_bubble_controller_unittest.cc 6 chrome/browser/speech/speech_recognition_bubble_gtk.cc 7 chrome/browser/speech/speech_recognition_tray_icon_controller.h 8 chrome/browser/task_manager/task_manager_resource_providers.cc 9 chrome/browser/ui/panels/panel_browser_frame_view.cc 10 chrome/browser/ui/search_engines/template_url_table_model.cc 11 chrome/browser/ui/search_engines/template_url_table_model.h 12 chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc 13 chrome/browser/ui/views/avatar_menu_button.cc 14 chrome/browser/ui/views/detachable_toolbar_view.cc 15 chrome/browser/ui/views/download/download_item_view.cc 16 chrome/browser/ui/views/extensions/extension_install_dialog_view.cc 17 chrome/browser/ui/views/location_bar/icon_label_bubble_view.h 18 chrome/browser/ui/views/location_bar/location_bar_view.cc 19 chrome/browser/ui/views/tab_icon_view.cc 20 chrome/browser/ui/views/tab_icon_view.h 21 chrome/browser/ui/views/tabs/tab_strip.cc Include, whitespace changes in 1 chrome/browser/automation/automation_provider_observers.cc 2 chrome/browser/background/background_application_list_model.h 3 chrome/browser/background/background_mode_manager.cc 4 chrome/browser/custom_home_pages_table_model.h 5 chrome/browser/download/download_util.cc 6 chrome/browser/extensions/extension_function_dispatcher.cc 7 chrome/browser/extensions/extension_install_dialog.cc 8 chrome/browser/extensions/extension_install_dialog.h 9 chrome/browser/ntp_background_util.cc 10 chrome/browser/speech/speech_recognition_bubble.h 11 chrome/browser/task_manager/task_manager.h 12 chrome/browser/ui/cocoa/infobars/mock_confirm_infobar_delegate.cc 13 chrome/browser/ui/cocoa/infobars/mock_link_infobar_delegate.cc 14 chrome/browser/ui/cocoa/task_manager_mac.h 15 chrome/browser/ui/views/about_chrome_view.cc 16 chrome/browser/ui/views/avatar_menu_bubble_view.cc 17 chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc 18 chrome/browser/ui/views/download/download_item_view.h 19 chrome/browser/ui/views/find_bar_view.cc 20 chrome/browser/ui/views/infobars/extension_infobar.cc 21 chrome/browser/ui/views/notifications/balloon_view.cc 22 chrome/browser/ui/views/page_info_bubble_view.cc 23 chrome/browser/ui/views/tabs/base_tab.cc 24 chrome/browser/ui/views/tabs/tab.cc 25 chrome/browser/ui/views/toolbar_view.cc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140628

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+556 lines, -510 lines) Patch
M chrome/browser/automation/automation_provider_observers.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_observers_chromeos.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_application_list_model.h View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/background/background_application_list_model.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/background/background_mode_manager.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/background/background_mode_manager_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 1 2 3 4 5 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/custom_home_pages_table_model.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/download_extension_api.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_util.cc View 4 chunks +23 lines, -21 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_dialog.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_dialog.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.h View 1 2 3 4 5 6 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_ui.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_uninstall_dialog.h View 1 2 3 4 5 6 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_uninstall_dialog.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/media/media_stream_capture_indicator.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/media/media_stream_capture_indicator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ntp_background_util.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/speech/speech_recognition_bubble.h View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/speech/speech_recognition_bubble.cc View 6 chunks +23 lines, -23 lines 0 comments Download
M chrome/browser/speech/speech_recognition_bubble_controller_unittest.cc View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/speech/speech_recognition_tray_icon_controller.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/speech/speech_recognition_tray_icon_controller.cc View 3 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/status_icons/desktop_notification_balloon.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.h View 1 2 3 4 5 6 4 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/task_manager/task_manager_notification_resource_provider.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.h View 1 2 3 4 5 6 12 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 1 2 3 4 5 6 7 8 16 chunks +20 lines, -17 lines 0 comments Download
M chrome/browser/task_manager/task_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/task_manager_worker_resource_provider.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view_unittest.mm View 1 2 3 4 5 6 7 8 9 10 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/mock_confirm_infobar_delegate.cc View 1 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/mock_link_infobar_delegate.cc View 1 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/table_row_nsimage_cache.h View 1 2 3 4 5 6 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/table_row_nsimage_cache.mm View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/table_row_nsimage_cache_unittest.mm View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/task_manager_mac.h View 1 2 3 4 5 6 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/task_manager_mac.mm View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/task_manager_mac_unittest.mm View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/speech_recognition_bubble_gtk.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/search_engines/template_url_table_model.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/search_engines/template_url_table_model.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/about_chrome_view.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/avatar_menu_bubble_view.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/avatar_menu_button.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/avatar_menu_button.cc View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/detachable_toolbar_view.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view.h View 1 4 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view.cc View 8 chunks +97 lines, -97 lines 0 comments Download
M chrome/browser/ui/views/dropdown_bar_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/dropdown_bar_view.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/find_bar_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/find_bar_view.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/infobars/extension_infobar.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/location_bar/icon_label_bubble_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/keyword_hint_view.cc View 5 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/menu_item_view_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/page_info_bubble_view.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/speech_recognition_bubble_views.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/tab_icon_view.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tab_icon_view.cc View 1 2 3 4 6 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/tabs/base_tab.cc View 1 2 3 4 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 1 2 3 4 5 6 7 8 9 10 8 chunks +23 lines, -22 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 2 3 4 5 7 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 2 3 4 5 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/theme_background.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 1 6 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_login_handler.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/browser_options_handler2.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/manage_profile_handler2.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/task_manager/task_manager_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/web_ui_util.h View 1 2 3 4 5 6 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_util.cc View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pkotwicz
8 years, 6 months ago (2012-05-31 22:56:18 UTC) #1
jianli
Your changes to panel_browser_frame_view.* are not needed. I've made the conversion when I worked on ...
8 years, 6 months ago (2012-05-31 23:41:24 UTC) #2
sky
LGTM
8 years, 6 months ago (2012-05-31 23:48:40 UTC) #3
Satish
chrome/browser/speech LGTM
8 years, 6 months ago (2012-06-01 16:30:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10453101/39001
8 years, 6 months ago (2012-06-05 19:33:25 UTC) #5
commit-bot: I haz the power
Try job failure for 10453101-39001 (retry) on mac_rel for step "unit_tests". It's a second try, ...
8 years, 6 months ago (2012-06-05 20:18:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10453101/40003
8 years, 6 months ago (2012-06-05 20:40:03 UTC) #7
commit-bot: I haz the power
8 years, 6 months ago (2012-06-05 21:56:44 UTC) #8
Change committed as 140628

Powered by Google App Engine
This is Rietveld 408576698