Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1449)

Issue 10453040: Default to not omitting frame pointers in Release on Windows. (Closed)

Created:
8 years, 7 months ago by scottmg
Modified:
8 years, 6 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Default to not omitting frame pointers in Release on Windows. Fixes command line spam about Oy conflicting with Oy-. See https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/oOk3w2TWNKk Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140106

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
scottmg
8 years, 7 months ago (2012-05-25 18:35:44 UTC) #1
scottmg
Could one of you stamp, if it looks ok to you then?
8 years, 6 months ago (2012-05-31 22:56:28 UTC) #2
gab
lgtm
8 years, 6 months ago (2012-05-31 23:03:19 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 6 months ago (2012-05-31 23:04:16 UTC) #4
scottmg
doh, Siggi?
8 years, 6 months ago (2012-05-31 23:05:49 UTC) #5
Sigurður Ásgeirsson
lgtm
8 years, 6 months ago (2012-06-01 12:50:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10453040/1
8 years, 6 months ago (2012-06-01 12:50:51 UTC) #7
commit-bot: I haz the power
Try job failure for 10453040-1 (retry) (retry) on win_rel for step "browser_tests" (clobber build). It's ...
8 years, 6 months ago (2012-06-01 19:49:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10453040/1
8 years, 6 months ago (2012-06-01 19:51:31 UTC) #9
commit-bot: I haz the power
8 years, 6 months ago (2012-06-01 21:52:13 UTC) #10
Change committed as 140106

Powered by Google App Engine
This is Rietveld 408576698