Debug crash in WebstoreInstaller::StartDownload()

Debug crash in WebstoreInstaller::StartDownload()

WebstoreInstaller is RefCounted, so there's no reason to make it base::Unretained, which just opens up a deletion race, or appears to.
controller_ may be NULL. NavigationController::GetActiveEntry() may be NULL.

This crash has persisted at a low, not quite dismissible frequency for a long time.

BUG=126013
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141771

[benjhayden, 2012-05-31 13:32:34]

PTAL

[Randy Smith (Not in Mondays), 2012-05-31 18:01:36]

I don't think I have anything to contribute to this review--I don't have the
context for the surrounding code.  Removing myself from the review list for that
reason.  If you or Aaron think that there's something that I should look at,
just yell and I'll jump back in.

[benjhayden, 2012-06-09 15:20:01]

Antony, Aaron, PTAL.

[Aaron Boodman, 2012-06-11 21:53:42]

http://codereview.chromium.org/10453039/diff/12001/chrome/browser/extensions/...
File chrome/browser/extensions/webstore_installer.cc (right):

http://codereview.chromium.org/10453039/diff/12001/chrome/browser/extensions/...
chrome/browser/extensions/webstore_installer.cc:304: if (file.empty() ||
!controller_ || !controller_->GetWebContents()) {
How can controller_ be NULL?

[benjhayden, 2012-06-12 17:51:53]

http://codereview.chromium.org/10453039/diff/12001/chrome/browser/extensions/...
File chrome/browser/extensions/webstore_installer.cc (right):

http://codereview.chromium.org/10453039/diff/12001/chrome/browser/extensions/...
chrome/browser/extensions/webstore_installer.cc:304: if (file.empty() ||
!controller_ || !controller_->GetWebContents()) {
On 2012/06/11 21:53:42, Aaron Boodman wrote:
> How can controller_ be NULL?

Changed the c-tor to validate it. PTAL.

[Aaron Boodman, 2012-06-12 17:54:19]

LGTM

[asargent_no_longer_on_chrome, 2012-06-12 18:01:49]

LGTM

[commit-bot: I haz the power, 2012-06-12 19:10:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benjhayden@chromium.org/10453039/22002

[commit-bot: I haz the power, 2012-06-12 20:59:31]

Try job failure for 10453039-22002 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-06-12 21:20:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benjhayden@chromium.org/10453039/22002

[commit-bot: I haz the power, 2012-06-12 22:56:16]

Change committed as 141771