Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 10453037: Deprecate FileUtilities::getFileSize and getFileModifiedTime (Closed)

Created:
8 years, 7 months ago by kinuko
Modified:
8 years, 6 months ago
Reviewers:
tony, Avi (use Gerrit)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Deprecate FileUtilities::getFileSize and getFileModifiedTime as they are no longer used in WebKit. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139542

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -135 lines) Patch
M content/browser/renderer_host/file_utilities_message_filter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/file_utilities_message_filter.cc View 2 chunks +0 lines, -37 lines 0 comments Download
M content/common/file_utilities_messages.h View 1 chunk +0 lines, -11 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M content/worker/worker_webkitplatformsupport_impl.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M webkit/glue/webfileutilities_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/glue/webfileutilities_impl.cc View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinuko
Follow up patch for https://src.chromium.org/viewvc/chrome?view=rev&revision=139022 Could you PTL? avi: content/ tony: webkit/
8 years, 6 months ago (2012-05-28 14:27:55 UTC) #1
Avi (use Gerrit)
Whooo!!!! LGTM!
8 years, 6 months ago (2012-05-28 15:12:11 UTC) #2
tony
LGTM
8 years, 6 months ago (2012-05-29 17:30:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/10453037/1
8 years, 6 months ago (2012-05-30 09:18:12 UTC) #4
commit-bot: I haz the power
Try job failure for 10453037-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 6 months ago (2012-05-30 12:59:37 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-05-30 14:55:42 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698