Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 10453009: Fixed Array.prototype.reverse() behavior when array is frozen or array elements are not writable an… (Closed)

Created:
8 years, 7 months ago by ioseb
Modified:
8 years, 5 months ago
CC:
v8-dev, Michael Starzinger, Michael Starzinger (Google), rossberg
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Fixed Array.prototype.reverse() behavior when array is frozen or array elements are not writable and configurable. BUG=v8:1992 TEST=mjsunit/sparse-array-reverse

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -2 lines) Patch
M src/array.js View 3 chunks +71 lines, -2 lines 0 comments Download
M src/messages.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/sparse-array-reverse.js View 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ioseb
Functionality is aligned to those found in recent stable version of FF and WebKit nightly. ...
8 years, 7 months ago (2012-05-24 18:19:38 UTC) #1
Michael Starzinger
This patch is functionally correct, but it looks like it is introducing a huge overhead ...
8 years, 7 months ago (2012-05-25 07:53:10 UTC) #2
ioseb
On 2012/05/25 07:53:10, Michael Starzinger wrote: > This patch is functionally correct, but it looks ...
8 years, 7 months ago (2012-05-25 08:08:56 UTC) #3
Michael Starzinger
I don't think V8 has support for fast access of property attributes at the moment. ...
8 years, 7 months ago (2012-05-25 08:48:10 UTC) #4
ioseb
I agree, this doesn't look like a solid solution. > But I don't want to ...
8 years, 7 months ago (2012-05-25 09:27:40 UTC) #5
Michael Starzinger
8 years, 5 months ago (2012-07-03 12:57:09 UTC) #6
Code Review Spring Cleaning: Since we agreed that this particular fix is not
efficient enough, I am closing this CL now.

Powered by Google App Engine
This is Rietveld 408576698