Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 10453003: Removed superfluous dcheck. (Closed)

Created:
8 years, 7 months ago by Andrew T Wilson (Slow)
Modified:
8 years, 7 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews
Visibility:
Public.

Description

Removed superfluous dcheck. Removed dcheck from HandleShowSyncSetup() because the promo page likes to call this routine when it's loaded/reloaded. There's no harm in calling this twice since OpenSyncSetup() handles the case when the overlay is already visible. The other half of this bug is r125797 - if we reload the page, then before the page is reloaded the original SyncSetupHandler should get some kind of a notification so it can unregister itself from LoginUIService. BUG=129490 TEST=Signin to acct with custom passphrase via promo, when prompted for passphrase hit reload, should not get a crash. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138843

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Andrew T Wilson (Slow)
Just a quick one-line fix (deleted dcheck).
8 years, 7 months ago (2012-05-24 01:02:39 UTC) #1
James Hawkins
On 2012/05/24 01:02:39, Andrew T Wilson wrote: > Just a quick one-line fix (deleted dcheck). ...
8 years, 7 months ago (2012-05-24 17:46:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atwilson@chromium.org/10453003/1
8 years, 7 months ago (2012-05-24 17:48:36 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-24 18:22:05 UTC) #4
Try job failure for 10453003-1 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

Powered by Google App Engine
This is Rietveld 408576698