Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: chrome/browser/ui/views/ash/ime_controller_chromeos.cc

Issue 10452042: Fixing french keyboard handling (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fixed unit test Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/views/ash/ime_controller_chromeos.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/ash/ime_controller_chromeos.h" 5 #include "chrome/browser/ui/views/ash/ime_controller_chromeos.h"
6 6
7 #include "chrome/browser/chromeos/input_method/input_method_manager.h" 7 #include "chrome/browser/chromeos/input_method/input_method_manager.h"
8 #include "ui/base/accelerators/accelerator.h"
8 9
9 bool ImeController::HandleNextIme() { 10 bool ImeController::HandleNextIme() {
10 chromeos::input_method::InputMethodManager* manager = 11 chromeos::input_method::InputMethodManager* manager =
11 chromeos::input_method::InputMethodManager::GetInstance(); 12 chromeos::input_method::InputMethodManager::GetInstance();
12 return manager->SwitchToNextInputMethod(); 13 return manager->SwitchToNextInputMethod();
13 } 14 }
14 15
15 bool ImeController::HandlePreviousIme() { 16 bool ImeController::HandlePreviousIme() {
16 chromeos::input_method::InputMethodManager* manager = 17 chromeos::input_method::InputMethodManager* manager =
17 chromeos::input_method::InputMethodManager::GetInstance(); 18 chromeos::input_method::InputMethodManager::GetInstance();
18 return manager->SwitchToPreviousInputMethod(); 19 return manager->SwitchToPreviousInputMethod();
19 } 20 }
20 21
21 bool ImeController::HandleSwitchIme(const ui::Accelerator& accelerator) { 22 bool ImeController::HandleSwitchIme(const ui::Accelerator& accelerator) {
22 chromeos::input_method::InputMethodManager* manager = 23 chromeos::input_method::InputMethodManager* manager =
23 chromeos::input_method::InputMethodManager::GetInstance(); 24 chromeos::input_method::InputMethodManager::GetInstance();
24 return manager->SwitchInputMethod(accelerator); 25 return manager->SwitchInputMethod(accelerator);
25 } 26 }
27
28 ui::Accelerator ImeController::RemapAccelerator(
29 const ui::Accelerator& accelerator) {
30 ui::KeyboardCode key = accelerator.key_code();
31 int modifiers = accelerator.modifiers();
32 // On French keyboards the user needs to press a number key in conjunction
33 // with the shift key. To get the right accelerator from our static table
34 // we modify the received accelerator to match this.
35 if (key >= ui::VKEY_0 && key <= ui::VKEY_9) {
36 // A keyboard layout can get changed by the user, so we perform quickly
37 // this cheap layout test.
38 // See http://crbug.com/129017 for more details.
39 if (UsingFrenchInputMethod()) {
40 // We toggle the shift key to get the correct accelerator from our table.
41 modifiers ^= ui::EF_SHIFT_DOWN;
42 }
43 }
44 return ui::Accelerator(key, modifiers);
45 }
46
47 bool ImeController::UsingFrenchInputMethod() const {
48 chromeos::input_method::InputMethodManager* manager =
49 chromeos::input_method::InputMethodManager::GetInstance();
50 const chromeos::input_method::InputMethodDescriptor& descriptor =
51 manager->GetCurrentInputMethod();
52 const std::string& layout = descriptor.id();
53 return (layout == "xkb:fr::fra" || layout == "xkb:be::fra");
54 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/ash/ime_controller_chromeos.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698