Fix bug when a variable is used in try/catch and accessed trough HFieldGet and HFieldSet: reference…

lib/compiler/implementation/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class SsaCodeGeneratorTask extends CompilerTask {
   final JavaScriptBackend backend;
   SsaCodeGeneratorTask(JavaScriptBackend backend)
       : this.backend = backend,
         super(backend.compiler);
   String get name() => 'SSA code generator';
@@ skipping 1550 matching lines @@
       assert(superMethod.kind == ElementKind.GETTER);
       String methodName =
           compiler.namer.getterName(currentLibrary, superMethod.name);
       buffer.add('$className.prototype.$methodName.call()');
     }
     endExpression(JSPrecedence.CALL_PRECEDENCE);
     world.registerStaticUse(superMethod);
   }
 
   visitFieldGet(HFieldGet node) {
-    if (node.receiver !== null) {
+    if (!node.isFromActivation()) {
       String name =
           compiler.namer.instanceFieldName(currentLibrary, node.name);
       beginExpression(JSPrecedence.MEMBER_PRECEDENCE);
       use(node.receiver, JSPrecedence.MEMBER_PRECEDENCE);
       buffer.add('.');
       buffer.add(name);
       beginExpression(JSPrecedence.MEMBER_PRECEDENCE);
     } else {
-      buffer.add(JsNames.getValid(node.name.slowToString()));
+      use(node.receiver, JSPrecedence.EXPRESSION_PRECEDENCE);
     }
   }
 
   visitFieldSet(HFieldSet node) {
     String name;
-    if (node.receiver !== null) {
+    if (!node.isFromActivation()) {
       name =
           compiler.namer.instanceFieldName(currentLibrary, node.name);
       beginExpression(JSPrecedence.ASSIGNMENT_PRECEDENCE);
       use(node.receiver, JSPrecedence.MEMBER_PRECEDENCE);
       buffer.add('.');
       buffer.add(name);
     } else {
       // TODO(ngeoffray): Remove the 'var' once we don't globally box
       // variables used in a try/catch.
-      name = JsNames.getValid(node.name.slowToString());
-      declareVariable(name);
+      if (!isGeneratingExpression()) {
+        buffer.add('var ');
+      }
+      use(node.receiver, JSPrecedence.EXPRESSION_PRECEDENCE);
     }
     buffer.add(' = ');
     use(node.value, JSPrecedence.ASSIGNMENT_PRECEDENCE);
     if (node.receiver !== null) {
       endExpression(JSPrecedence.ASSIGNMENT_PRECEDENCE);
     }
   }
 
   visitForeign(HForeign node) {
     String code = node.code.slowToString();
@@ skipping 127 matching lines @@
     } else {
       beginExpression(JSPrecedence.PREFIX_PRECEDENCE);
       buffer.add('!');
       use(input, JSPrecedence.PREFIX_PRECEDENCE);
       endExpression(JSPrecedence.PREFIX_PRECEDENCE);
     }
   }
 
   visitParameterValue(HParameterValue node) {
     assert(isGenerateAtUseSite(node));
-    buffer.add(parameterNames[node.element]);
+    if (parameterNames[node.element] == null) {
+      buffer.add(temporary(node));
+    } else {
+      buffer.add(parameterNames[node.element]);
+    }
   }
 
   visitPhi(HPhi node) {
     String operation = logicalOperations[node];
     if (operation !== null) {
       emitLogicalOperation(node, operation);
     } else {
       HPhi canonicalPhi = phiEquivalence.getRepresentative(node);
       buffer.add('${temporary(canonicalPhi)}');
     }
@@ skipping 870 matching lines @@
       startBailoutSwitch();
     }
   }
 
   void endLabeledBlock(HLabeledBlockInformation labeledBlockInfo) {
     if (labeledBlockInfo.body.start.hasGuards()) {
       endBailoutSwitch();
     }
   }
 }