Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(74)

Issue 10452024: Merge 138264 - Re-enable embedded identities in URLs for HTTP authentication. (Closed)

Created:
7 years, 2 months ago by asanka
Modified:
7 years, 2 months ago
Reviewers:
cbentzel
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Merge 138264 - Re-enable embedded identities in URLs for HTTP authentication. (Second attempt) This effectively reverts r121506. BUG=123150 TEST=net_unittests. Username/passwords specified in URLs work. XmlHttpRequests() with credentials passed as arguments work. Review URL: https://chromiumcodereview.appspot.com/10412025 TBR=asanka@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138992

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+332 lines, -11 lines) Patch
M net/http/http_auth_controller.cc View 1 chunk +11 lines, -7 lines 0 comments Download
M net/http/http_network_transaction_spdy2_unittest.cc View 2 chunks +145 lines, -2 lines 0 comments Download
M net/http/http_network_transaction_spdy3_unittest.cc View 2 chunks +145 lines, -2 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
asanka
Manually built and tested on branch.
7 years, 2 months ago (2012-05-24 22:45:55 UTC) #1
asanka
On 2012/05/24 22:45:55, asanka wrote: > Manually built and tested on branch. Patchset 1 is ...
7 years, 2 months ago (2012-05-24 22:53:14 UTC) #2
cbentzel
7 years, 2 months ago (2012-05-25 01:03:37 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698