chrome/browser/extensions/extension_install_ui.h - Issue 10452009: Improve the UI for disabling off-store extension install.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_install_ui.h

Issue 10452009: Improve the UI for disabling off-store extension install. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed comments, fixed tests Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_install_ui.h

diff --git a/chrome/browser/extensions/extension_install_ui.h b/chrome/browser/extensions/extension_install_ui.h

index 8316d69321972a40d83514b6078d00cb3d584c04..af4da9b482bfb0b546cc5e0cf90be022a613f023 100644

--- a/chrome/browser/extensions/extension_install_ui.h

+++ b/chrome/browser/extensions/extension_install_ui.h

@@ -31,7 +31,7 @@ class DictionaryValue;

namespace extensions {

class BundleInstaller;

class Extension;

-class ExtensionNoConfirmWebstorePrivateApiTest;

+class ExtensionWebstorePrivateApiTest;

} // namespace extensions

// Displays all the UI around extension installation.

@@ -226,7 +226,7 @@ class ExtensionInstallUI : public ImageLoadingTracker::Observer {

static void OpenAppInstalledUI(Browser* browser, const std::string& app_id);

protected:

- friend class extensions::ExtensionNoConfirmWebstorePrivateApiTest;

+ friend class extensions::ExtensionWebstorePrivateApiTest;

friend class WebstoreInlineInstallUnpackFailureTest;

// Disables showing UI (ErrorBox, etc.) for install failures. To be used only