Source/WebCore/html/HTMLFieldSetElement.cpp - Issue 10451107: Merge 118721 - Form controls in <fieldset disabled> should not be validated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/html/HTMLFieldSetElement.cpp

Issue 10451107: Merge 118721 - Form controls in <fieldset disabled> should not be validated. (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1132/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/forms/fieldset/validation-in-fieldset-expected.txt ('k') | Source/WebCore/html/HTMLFormControlElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/html/HTMLFieldSetElement.cpp

===================================================================

--- Source/WebCore/html/HTMLFieldSetElement.cpp (revision 119198)

+++ Source/WebCore/html/HTMLFieldSetElement.cpp (working copy)

@@ -50,9 +50,9 @@

// This element must be updated before the style of nodes in its subtree gets recalculated.

HTMLFormControlElement::disabledAttributeChanged();

- for (Node* currentNode = this; currentNode; currentNode = currentNode->traverseNextNode(this)) {

+ for (Node* currentNode = this->traverseNextNode(this); currentNode; currentNode = currentNode->traverseNextNode(this)) {

if (currentNode && currentNode->isElementNode() && toElement(currentNode)->isFormControlElement())

- static_cast<HTMLFormControlElement*>(currentNode)->setNeedsStyleRecalc();

+ static_cast<HTMLFormControlElement*>(currentNode)->ancestorDisabledStateWasChanged();

}