Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 10451102: fix a memory leak and add a suppression (Closed)

Created:
8 years, 6 months ago by Evan Stade
Modified:
8 years, 6 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

fix a couple apparent memory leaks and add a suppression and remove a suppression BUG=130640, 114979 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140183

Patch Set 1 #

Patch Set 2 : remove suppression no longer needed #

Patch Set 3 : don't segfault #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -47 lines) Patch
M chrome/browser/ui/gtk/bookmarks/bookmark_editor_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_tree_model.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_utils_gtk.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_theme_service.h View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_theme_service.cc View 1 2 3 4 chunks +28 lines, -29 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_tree.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/task_manager_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/heapcheck/suppressions.txt View 1 2 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Stade
8 years, 6 months ago (2012-05-31 22:26:09 UTC) #1
Elliot Glaysher
lgtm
8 years, 6 months ago (2012-05-31 22:31:39 UTC) #2
Evan Stade
I have changed the signature of the GetFolderIcon() function (and its sibling) to pass a ...
8 years, 6 months ago (2012-06-01 21:07:04 UTC) #3
Elliot Glaysher
8 years, 6 months ago (2012-06-01 21:08:51 UTC) #4
slgtm

Powered by Google App Engine
This is Rietveld 408576698