Issue 10451092: Avoid overdeep recursion in regexp where a guarded expression with a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10451092: Avoid overdeep recursion in regexp where a guarded expression with a (Closed)

Created:
8 years, 6 months ago by Erik Corry

Modified:
8 years, 6 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Avoid overdeep recursion in regexp where a guarded expression with a minimum repetition count is inside another quantifier. Bug=129926 Committed: https://code.google.com/p/v8/source/detail?r=11686

Patch Set 1 #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -39 lines)			Patch
M	src/jsregexp.h	View	10 chunks	+43 lines, -22 lines	0 comments	Download
M	src/jsregexp.cc	View	9 chunks	+30 lines, -17 lines	2 comments	Download
M	test/mjsunit/regexp-capture-3.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

LGTM. Nit in the description: "BUG=129926" in a separate line would look nicer. https://chromiumcodereview.appspot.com/10451092/diff/1/src/jsregexp.cc File ...

8 years, 6 months ago (2012-05-31 11:56:23 UTC) #2

Erik Corry

8 years, 6 months ago (2012-05-31 13:51:43 UTC) #3

https://chromiumcodereview.appspot.com/10451092/diff/1/src/jsregexp.cc
File src/jsregexp.cc (right):

https://chromiumcodereview.appspot.com/10451092/diff/1/src/jsregexp.cc#newcod...
src/jsregexp.cc:5617: ZoneList<GuardedAlternative>* alts = alternatives();
On 2012/05/31 11:56:23, ulan wrote:
> We don't check recursion_depth here, because nesting of choice nodes is
limited
> somewhere else?

Yes, it's only LoopChoiceNodes that can lead to unrestricted recursion.

Expand Messages | Collapse Messages