Issue 10451065: Prepare push to trunk. Now working on version 3.11.8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10451065: Prepare push to trunk. Now working on version 3.11.8. (Closed)

Created:
8 years, 6 months ago by Sven Panne

Modified:
8 years, 6 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Prepare push to trunk. Now working on version 3.11.8. R=jkummerow@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11673

Patch Set 1 #

Total comments: 3

Patch Set 2 : Review comments #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	ChangeLog	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 6 months ago (2012-05-29 13:13:33 UTC) #2

LGTM with comments. Short ChangeLog entries FTW :-)

https://chromiumcodereview.appspot.com/10451065/diff/1/ChangeLog
File ChangeLog (right):

https://chromiumcodereview.appspot.com/10451065/diff/1/ChangeLog#newcode3
ChangeLog:3: Fixed JSObject::SetPropertyForResult. (issue 2153)
Don't need this (bug wasn't present in last trunk version, right?)

https://chromiumcodereview.appspot.com/10451065/diff/1/ChangeLog#newcode5
ChangeLog:5: Enabled map transitions for accessor properties.
Don't need this (invisible to embedders, right?).

https://chromiumcodereview.appspot.com/10451065/diff/1/ChangeLog#newcode7
ChangeLog:7: Clear pending functions list in FuncNameInferrer when it closes.
(issue 2146)
nit: 80 columns. Also, I'd change the description to something more
understandable, like "Fixed function name inference in a few cases". But then
it's basically indistinguishable from the next entry. So we don't need this
either.

Expand Messages | Collapse Messages