Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 10451056: mac ninja/make: Cache _sdk_base_dir at class level instead of instance level. (Closed)

Created:
8 years, 6 months ago by Nico
Modified:
8 years, 6 months ago
Reviewers:
Mark Mentovai, scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

mac ninja/make: Cache _sdk_base_dir at class level instead of instance level. Makes gyp with GYP_GENERATORS=ninja file generation 20% faster. BUG=82230 TEST=none Committed: https://code.google.com/p/gyp/source/detail?r=1398

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M pylib/gyp/xcode_emulation.py View 4 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
Running xcode-select for every single target apparently takes a while.
8 years, 6 months ago (2012-05-28 17:23:18 UTC) #1
scottmg
8 years, 6 months ago (2012-05-28 18:44:27 UTC) #2
holiday lgtm

(xcode-select can't be different per target, right?)

Powered by Google App Engine
This is Rietveld 408576698