Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: media/filters/ffmpeg_video_decoder.h

Issue 10451051: Provide a Chrome-owned buffer to FFmpeg for video decoding, instead of (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/ffmpeg_video_decoder.h
===================================================================
--- media/filters/ffmpeg_video_decoder.h (revision 140753)
+++ media/filters/ffmpeg_video_decoder.h (working copy)
@@ -37,6 +37,11 @@
// encountered.
void set_decryptor(AesDecryptor* decryptor);
+ // Callback called from within FFmpeg to allocate a buffer based on
+ // the dimensions of |codec_context_|. See AVCodecContext.get_buffer
+ // documentation inside FFmpeg.
+ int GetVideoBuffer(AVFrame *frame);
scherkus (not reviewing) 2012/06/14 02:21:33 pointer w/ type
+
protected:
virtual ~FFmpegVideoDecoder();
@@ -70,10 +75,6 @@
// Reset decoder and call |reset_cb_|.
void DoReset();
- // Allocates a video frame based on the current format and dimensions based on
- // the current state of |codec_context_|.
- scoped_refptr<VideoFrame> AllocateVideoFrame();
-
// This is !is_null() iff Initialize() hasn't been called.
base::Callback<MessageLoop*()> message_loop_factory_cb_;

Powered by Google App Engine
This is Rietveld 408576698